Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date_parser deprecation warning #478

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Fix date_parser deprecation warning #478

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
107b243
Fix `date_parser` deprecation warning
gtopper Dec 17, 2023
7dae226
Fix pandas<2 compatibility
gtopper Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions storey/sources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,20 +944,12 @@ def _init(self):
path,
header=0,
parse_dates=self._dates_indices,
date_parser=self._datetime_from_timestamp,
date_format=self._timestamp_format,
assaf758 marked this conversation as resolved.
Show resolved Hide resolved
storage_options=self._storage_options,
)
self._validate_fields(df, path)
self._dfs.append(df)

def _datetime_from_timestamp(self, timestamp):
if timestamp == "" or pd.isna(timestamp):
return None
if self._timestamp_format:
return pandas.to_datetime(timestamp, format=self._timestamp_format).floor("u").to_pydatetime()
else:
return datetime.fromisoformat(timestamp)

def _get_element(self, body: dict, columns: List[str]):
if self._build_dict:
return body
Expand Down