-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ConcurrentExecution
step
#511
Conversation
Based on the preexisting internal `_ConcurrentJobExecution` class. With support for three concurrency mechanisms: asyncio, threading, and multiprocessing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the issue with serializable context, everything else in the pull request looks good. Do we want to address this issue within the current pull request? It seems that the 'pass_context' flag may not be the best solution for the problem.
To make mlrun context serializable isn't something we can do in storey anyway.
Why is it the flag's fault? :) Do you have some change in mind? |
Can you check if indeed https://github.com/uqfoundation/dill can serialize lambdas? |
@assaf758, it can, but it's not obvious how to use that to solve the problem. I'll try to find a way. |
It turns out that mlrun |
ML-6015
Based on the preexisting internal
_ConcurrentJobExecution
class. With support for three concurrency mechanisms: asyncio, threading, and multiprocessing.