Fix safe upgrade #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though there it kubeadm_token_ttl=0 which means that kubeadm token never expires, it is not present in `kubeadm token list` after cluster is provisioned (at least after it is running for some time) and there is issue regarding this kubernetes/kubeadm#335, so we need to create a new temporary token during the cluster upgrade.
mlushpenko
pushed a commit
that referenced
this pull request
Sep 1, 2018
…edns appropriately use dns_domain instead of cluster_name for coredns for coredns config map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A kubespray cluster is running for some time and you want to safely update it to the newer version using
upgrade_cluster.ymlIt will fail during
[kubernetes/kubeadm : Join to cluster if needed]with error:Expected result
kubeadm joinwill succeed askubeadm_token_ttlis set to 0 which means that token should never expire, but it is not present inkubeadm token listafter cluster is provisioned (at least after it is running for some time)Related issues
kubernetes/kubeadm#335
Solution
Create a new temporary token before the
kubeadm joincommandRefactoring issues
Not sure what to do with
kubeadm_tokenandkubeadm_token_ttlthat are defined inroles\kubespray-defaults\defaults\main.yml. The code I added doesn't really breake anything as much as I tested, but looks likekubeadm_token_ttlis not respected, so perhaps it can be removed.kubeadm_tokenis also used for master config, so can stay untouched but it's a bit weird that that token is not used then duringkubeadm joinbecause I override it with newly generated one. Please suggest if you have ideas how to optimize it.