making fb_server_fbml html_safe for rails 3 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y setting width of the fb_server_fbml rendered iframe (only way which works)
mmangino
added a commit
that referenced
this pull request
Dec 1, 2011
making fb_server_fbml html_safe for rails 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added functionality to make fb_server_fbml html_safe so it renders properly in rails 3. I've also noticed that unless you explicitly set the width on fb_server_fbml facebook doesn't respect it, e.g. just in the style tag, so I added a param to the fb_server_fbml function for width. I've updated the tests as well.