fix(profiles): fix encoding of profiles on Node.js v16+

mmarchini-oss · Nov 7, 2022 · ab0f580 · ab0f580
1 parent f683b19
commit ab0f580
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -17,6 +17,9 @@ jobs:
           - version: 10.x
           - version: 12.x
           - version: 14.x
+          - version: 16.x
+          - version: 18.x
+          - version: 19.x
         # TODO(mmarchini): fix tests on windows and re-enable it here
         os: [ubuntu-latest, macos-latest]
 

diff --git a/lib/commands/cpu-profile.js b/lib/commands/cpu-profile.js
@@ -20,7 +20,7 @@ async function run(host, port, stream, options={}) {
 
   const res = await client.post("Profiler.stop");
   const { profile } = res;
-  stream.write(JSON.stringify(profile), res);
+  stream.write(JSON.stringify(profile));
 
   await client.post("Profiler.disable");
   client.disconnect();

diff --git a/lib/commands/heap-profile.js b/lib/commands/heap-profile.js
@@ -17,7 +17,7 @@ async function run(host, port, stream, options={}) {
 
   const res = await client.post("HeapProfiler.stopSampling");
   const { profile } = res;
-  stream.write(JSON.stringify(profile), res);
+  stream.write(JSON.stringify(profile));
 
   client.disconnect();
 }