Skip to content

Commit

Permalink
iceberg: use uppercase strings to represent data file format
Browse files Browse the repository at this point in the history
Iceberg is a bit inconsistent when defining this. Some libraries
(pyiceber in particular) requires it to be upper case string. For
Redpanda the case doesn't matter as we always lower case the value when
parsing it.

Signed-off-by: Michał Maślanka <michal@redpanda.com>
  • Loading branch information
mmaslankaprv committed Oct 30, 2024
1 parent adf22ec commit 1184f4b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/v/iceberg/manifest_entry_values.cc
Original file line number Diff line number Diff line change
Expand Up @@ -143,11 +143,11 @@ data_file_content_type content_from_int(int c) {
iobuf format_to_str(data_file_format f) {
switch (f) {
case data_file_format::avro:
return iobuf::from("avro");
return iobuf::from("AVRO");
case data_file_format::orc:
return iobuf::from("orc");
return iobuf::from("ORC");
case data_file_format::parquet:
return iobuf::from("parquet");
return iobuf::from("PARQUET");
}
}

Expand Down

0 comments on commit 1184f4b

Please sign in to comment.