Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh project a bit #231

Closed
wants to merge 1 commit into from
Closed

Conversation

maxwase
Copy link

@maxwase maxwase commented Aug 19, 2022

Update documentation, fix clippy lints, replace libc print macro in some places

Proofs:

MSRV for std printing in dtor:

#[ctor]
fn sturtup() {
    println!("Staring...");
}

fn main() {
    println!("Running...");
}

#[dtor]
fn shutdown() {
    println!("Shutting down!");
}

image

Print in ctor works on 1.31

image

@mmastrac
Copy link
Owner

Hi, thanks for this patch. Give me a bit to look at it. Do you have a link to the Rust changeset allowing println in shutdown?

I think I want to split this patch into two: one removing the libc_* methods and the other with general cleanup. I'll take a look at this and can split it manually.

@maxwase
Copy link
Author

maxwase commented Aug 22, 2022

Hi, thanks for this patch. Give me a bit to look at it. Do you have a link to the Rust changeset allowing println in shutdown?

I think I want to split this patch into two: one removing the libc_* methods and the other with general cleanup. I'll take a look at this and can split it manually.

I'm not sure what PR added an ability to use print in shutdown, I've just bisected it though compiler versions
UPD: Possibly this PR rust-lang/rust#76275

Also I of course can split this into two PR's, seems rational

@maxwase maxwase closed this Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants