This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
refactor(playsounds): use regex instead of elif chaining #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- makes an array (playsounds) containing all the .wav files in the /playsounds/ directory - matches message with regex ^\(\d+\)$ - checks if sound exists
for more information, see https://pre-commit.ci
just in case
mmattbtw
suggested changes
Feb 22, 2022
This reverts commit a3707f8.
mmattbtw
suggested changes
Feb 22, 2022
|
oh yeah i did some wonky stuff with numbers didn't i |
sound 1 = index 0. also replaced a print with log.info
mmattbtw
approved these changes
Feb 22, 2022
|
@all-contributors add @12beesinatrenchcoat for doc, and code |
|
I've put up a pull request to add @12beesinatrenchcoat! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #96.
Description
Because
if elsechaining hurts my soul.How Has This Been Tested
Ran two tests:
Should result in no sound being played.
Should result in "ninja: wow" going through to Uberduck.ai, and nothing else.
Checklist
Other information