-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ETL information to the hydra config to help solve #37 #40
Conversation
…earrangements to the API
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #40 +/- ##
==========================================
- Coverage 84.85% 84.75% -0.10%
==========================================
Files 17 18 +1
Lines 1096 1102 +6
==========================================
+ Hits 930 934 +4
- Misses 166 168 +2 ☔ View full report in Codecov by Sentry. |
This also rearranges the API a bit so that the CONFIG_YAML file path is importable from the MEDS extract and so that the term "extract" is used instead of "extraction".
This solves most of #37, as this will ensure the ETL pipeline version info is all written in a structured form to disk, though it won't be as nice as the unified JSON files currently used in MEDS ETLs.