Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing command in the range-over-iterators file #555

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

wwwstephen
Copy link
Contributor

The range-over-iterators file does not include the command go run range-over-iterators.go, which is inconsistent with the rest of the project. This omission may confuse users, as they won’t know what to name their file or which command to run locally. I have fixed this.

@eliben
Copy link
Collaborator

eliben commented Sep 23, 2024

This looks fine, but can you please squish to a single commit?
This seems to mix up commits from a different PR and I want to tread carefully

@wwwstephen
Copy link
Contributor Author

OK, do you know what's the best way to do that? Will I just create a new PR?

@wwwstephen
Copy link
Contributor Author

OK, I've tried a few things and think the commit is now in correct order :-) Every day is a school day.

@eliben eliben merged commit 81ec07e into mmcgrana:master Sep 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants