-
Notifications
You must be signed in to change notification settings - Fork 25.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for additional search providers #1416
Comments
@mmistakes Would you also be interested in multiple language support ? |
Not sure I follow what you mean by multiple language support @nickgarlis. Could you expand on it some? |
@mmistakes I am not sure about Algolia but Lunr does not support any other languages other than English by default. Non English users might be interested in searching in their native language. My solution to this was to use a different .js file for the extra language that I wanted to support where I registered a new stemmer. We could also borrow some stemmers from this repository |
Ah ok. Yeah I dunno. If it can be done in a way to not over complicate setup. In my experience it can be tricky handling multiple languages with a theme because Jekyll core isn’t really all that friendly to it. Last thing I want to do is open a can of worms that can’t be supported well. |
@nickgarlis Possible solution would be leverage
Then you could load the appropriate .js and if one doesn't exist for the given <script src="{{ '/assets/js/lunr-{{ lang }}.js' | absolute_url }}"></script> |
That's exactly how I was thinking of doing it ! |
For what it's worth, Algolia is language agnostic :) Is there anything I could do to help you integrate jekyll-algolia? |
@pixelastic It's on my todo list. I just need to lay the ground work for it in the theme. |
Has a pull-request #1531 |
First thanks for the great theme @mmistakes, very useful. Should we keep this request open since google CSE is still not supported or should we open a new one to keep track of it? We were also looking to support google CSE and came upon this issue. |
@user414 Open a new issue so it can be tracked, if and when I get around to it. |
* Support Lunr and Algolia search providers * Document search providers and configuration * Update CHANGELOG and history close mmistakes#1416
* Support Lunr and Algolia search providers * Document search providers and configuration * Update CHANGELOG and history close mmistakes#1416
* Support Lunr and Algolia search providers * Document search providers and configuration * Update CHANGELOG and history close mmistakes#1416
Augment search feature by allowing support for different search providers, similar to what was done with commenting.
The text was updated successfully, but these errors were encountered: