-
Notifications
You must be signed in to change notification settings - Fork 25.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
absolute_url vs relative_url #1588
Comments
Are you correctly assigning Give |
Here's how to solve it. Closing as this is a duplicate. |
Thanks @mmistakes. I'd already tried that, but it doesn't quite solve the problem. When you set the build for Ideally, if you use a relative path instead, the url stops getting on the way. |
This is where multiple config files can come into place. You can daisy chain them in your build command.
# _config.yml
# contains all your normal configs # _config.dev.yml (or whatever you want to name it)
# add any variables you want to override for development purposes
url: http://localhost:4000 Then your Jekyll build command would change to |
Right on! Doing that solved it. Still think it would be easier to just use relative urls to avoid the "hackery" around how you start Jekyll, but this completely solved it. Thank you for the responsiveness! |
Where it makes sense replace asset paths and navigation related paths with `relative_url` filter. Leave SEO related `<head>` elements and social sharing links as `absolute_url`. Fixes #1588
Where it makes sense replace asset paths and navigation related paths with `relative_url` filter. Leave SEO related `<head>` elements and social sharing links as `absolute_url`. Fixes mmistakes#1588
Where it makes sense replace asset paths and navigation related paths with `relative_url` filter. Leave SEO related `<head>` elements and social sharing links as `absolute_url`. Fixes mmistakes#1588
Where it makes sense replace asset paths and navigation related paths with `relative_url` filter. Leave SEO related `<head>` elements and social sharing links as `absolute_url`. Fixes mmistakes#1588
bundle update
.bundle exec jekyll build
.Environment information
Expected behaviour
Seems like this theme uses
absolute_url
, which will yield urls like 0.0.0.0:PORT when you use it with docker. I've noticed that your other theme "so-simple" works well with docker as it usesrelative_url
. I was wondering if there's a reason for that. I'd be happy to update it all and send you a PR, but wanted to check with you first if there's a reason. Should all work the same after the update.The text was updated successfully, but these errors were encountered: