-
Notifications
You must be signed in to change notification settings - Fork 25.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footer breaks when using a browser toolbar #2281
Comments
There's a bit of JavaScript that evaluates the height of the page to determine how much space it needs to stick to the bottom of the page. My guess is the Moz and SEOrush toolsbars screw with that because they are adding their own sticky panels to the DOM. Not sure if there's anything I can do about how other scripts mess with the theme. |
The Mozbar is injecting inline CSS to the body.mozbar-margin-wGA7MhRhQ3WS {
margin-top: 43px;
position: absolute;
width: 100%;
} |
Okay. But I noticed on your website https://mademistakes.com/articles/, the footer doesn't break when using a toolbar. Perhaps, the solution could there? |
mademistakes.com is my personal site, it's not using the Minimal Mistakes theme at all. It's a custom built Jekyll site... with a completely different layout. |
The faux-sticky footer effect will need to be rethought to get around plugins that try to rewrite the height of the page. Flexbox might be able to help here instead of absolutely positioning the footer and then using the JavaScript hack to clear it. |
It would be awesome if it gets fixed. I was really worried that people who are using the toolbars wouldn't be able to access the pagination. They would simply assume that the site is broken. |
I use Chrome together with Mozbar Chrome extension from Moz to see the Domain Authority and Page Ranking score for every page I visit.
I noticed the theme footer breaks when I have enabled the toolbar as you can see in the screenshot below:
When I disabled it, the footer looks fine:
I also tried this with a different toolbar SEOQuake from SEMrush.
As you can see the footer breaks again.
It happens on my blog and It also happens here: https://mmistakes.github.io/minimal-mistakes/ as you can see from the screenshots. It is worse on my blog because it blocks the pagination.
You can easily recreate this by trying the Mozbar extension and then visit https://mmistakes.github.io/minimal-mistakes/.
The text was updated successfully, but these errors were encountered: