Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow menu falls under post links #2478

Closed
KiarashS opened this issue Apr 8, 2020 · 4 comments
Closed

Follow menu falls under post links #2478

KiarashS opened this issue Apr 8, 2020 · 4 comments

Comments

@KiarashS
Copy link

KiarashS commented Apr 8, 2020

I use latest version of minimal-mistakes, and when I tap Follow button in mobile devices, Follow menu falls under post links.

follow

@iBug
Copy link
Collaborator

iBug commented Apr 8, 2020

I managed to reproduce this on https://blog.kiarash.pro/. But to be honest, your setup looks strange to me in that instead of linking to the actual post, the title links to somewhere else. I'm afraid it's not the intended usage of the "article menu" page.

@KiarashS
Copy link
Author

KiarashS commented Apr 8, 2020

@iBug That's OK, because Post link is a feature of minimal-mistake.
According to this link.

@mmistakes
Copy link
Owner

Looks like a z-indexing issue when I refactored the follow me menu styling a few releases back. I don't personally use link posts so didn't notice the overlap.

Those elements have z-index: 10 which puts them over the follow links. Changing it to something like 5 seems to fix it.

.archive__item a {
    position: relative;
    z-index: 5;
}

If someone wants to submit a PR to fix that would be great. No idea when I'll get to it.

image

@mmistakes
Copy link
Owner

Looks like @iBug already took care of the fix in #2478. Thanks.

jesuswasrasta pushed a commit to jesuswasrasta/jesuswasrasta.github.io that referenced this issue Jul 8, 2020
* Fix mmistakes#2478 "Follow menu falls under post links"

* Do it the other way
mzaffran pushed a commit to mzaffran/mzaffran.github.io that referenced this issue Jan 4, 2021
* Fix mmistakes#2478 "Follow menu falls under post links"

* Do it the other way
kaitokikuchi pushed a commit to kaitokikuchi/kaitokikuchi.github.io that referenced this issue Sep 4, 2023
* Fix mmistakes#2478 "Follow menu falls under post links"

* Do it the other way
chukycheese pushed a commit to chukycheese/chukycheese.github.io that referenced this issue Sep 18, 2023
* Fix mmistakes#2478 "Follow menu falls under post links"

* Do it the other way
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants