-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
navigation links sidebar overlays main body text on small screens #396
Comments
Can you attach a screenshot of the overlap? I'm not seeing it. |
Ah yeah I see it. It's related to a pull request @ZenHarbinger submitted to cleanup the sidebar c3e2272 There's a bit of JavaScript in there that's probably not triggering properly on the custom sidebar shown in the Documentation section of the site. Definitely a bug. |
My bad, I guess there isn't always an author's button and it needs a hard width value. I can see if a better condition can be found. At least I'm assuming that this situation doesn't have the author button. I'll look at it when I get a chance. |
Sounds good. Thanks @ZenHarbinger And yeah there's no author button on these sorts of sidebars. Pretty sure that's why I originally hard-coded the width in there. Maybe fallback to that value if the author button isn't present so the sticky sidebar doesn't fire on smaller screens messing with the layout. |
How do you generate your minimized javascript? |
@ZenHarbinger Through a Docs: https://mmistakes.github.io/minimal-mistakes/docs/javascript/ |
Awesome, one thing, can you update the page; I instead of npm build:js it's npm run build:js at least it is for node 6.3, if it's still that for 4.x, nevermind. |
Good catch. It's a typo I missed. |
bundle update
.bundle exec jekyll build
.Expected behavior
navigation sidebar either disappears when screen too narrow or scrolls away as the page is scrolled, does not overlay text from main page
Steps to reproduce the behavior
Visit the below page on a smaller width screen and scroll down a little:
https://mmistakes.github.io/minimal-mistakes/docs/quick-start-guide/
The navigation sidebar text overlays the main text.
I'd personally prefer the navigation text to be hidden when the screen is too narrow (navigation is possible from elsewhere anyway)...
The text was updated successfully, but these errors were encountered: