Replace old Disqus script with Universal Embed Code #1179
Merged
+14
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmistakes
reviewed
Aug 16, 2017
| <div id="disqus_thread"></div> | ||
| <script> | ||
| var disqus_config = function () { | ||
| this.page.url = "{{ site.url }}{{ page.url }}"; // Replace PAGE_URL with your page's canonical URL variable |
There was a problem hiding this comment.
Replace site.url with Jekyll's absolute URL filter. This will cover users who need to use both site.url and site.baseurl.
this.page.url = "{{ page.url | absolute_url }}";
There was a problem hiding this comment.
Thanks for the advice ... updated ...
mmistakes
changed the title
|
Thanks for the PR and making that minor edit. |
|
thanks!! |
5 tasks
kkunapuli
pushed a commit
to kkunapuli/kkunapuli.github.io
that referenced
this pull request
May 30, 2019
* update embeddable disqus javascript * Update disqus.html
makaroniame
added a commit
to makaroniame/makaroniame-old.github.io
that referenced
this pull request
May 18, 2022
* update embeddable disqus javascript * Update disqus.html
jchwenger
pushed a commit
to jchwenger/jchwenger.github.io
that referenced
this pull request
May 5, 2023
* update embeddable disqus javascript * Update disqus.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code seems to not be working anymore, the new code is based from Universal Embed Code that Disquss introduced recently.
Source:
https://help.disqus.com/customer/portal/articles/472097-universal-embed-code