Prevent line breaking between icon & text in footer social links #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I think I have an alternative way of doing this that requires zero markup changes to the footer include. All that's needed is the following CSS added to .page__footer-follow .social-icons a {
white-space: nowrap;
}And it'll force the lines of text not to wrap. Which ends up looking like this on your site:
|
|
If you want to make that change instead I can merge this in. |
|
Ready for review, @mmistakes |
luispuerto
referenced
this pull request
in luispuerto/luispuerto-net
Jun 27, 2018
kkunapuli
pushed a commit
to kkunapuli/kkunapuli.github.io
that referenced
this pull request
May 30, 2019
sumeetmondal
pushed a commit
to sumeetmondal/sumeetmondal.github.io
that referenced
this pull request
Sep 10, 2019
jchwenger
pushed a commit
to jchwenger/jchwenger.github.io
that referenced
this pull request
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1659