Fix schema.org dates to ISO-8601 #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmistakes
reviewed
Dec 4, 2019
_includes/comment.html
Outdated
| @@ -13,7 +13,7 @@ <h3 class="comment__author" itemprop="author" itemscope itemtype="https://schema | |||
| <p class="comment__date"> | |||
| {% if include.date %} | |||
| {% if include.index %}<a href="#comment{{ include.index }}" itemprop="url">{% endif %} | |||
| <time datetime="{{ include.date | date_to_xmlschema }}" itemprop="datePublished">{{ include.date | date: "%B %d, %Y at %I:%M %p" }}</time> | |||
| <time datetime="{{ include.date | date_to_xmlschema }}" itemprop="datePublished">{{ include.date | date_to_xmlschema }}</time> | |||
There was a problem hiding this comment.
<time> is already using date_to_xmlschema for the datetime attribute. My understanding the time between <time></time> is the human readable format and not used.
There was a problem hiding this comment.
You're right ! I reverted it.
kamil-adam
pushed a commit
to twocolumn/minimal-mistakes
that referenced
this pull request
Apr 1, 2020
* Fix schema.org dates to ISO-8601 * Revert date_to_xmlschema in <time> tag
jesuswasrasta
pushed a commit
to jesuswasrasta/jesuswasrasta.github.io
that referenced
this pull request
Jul 8, 2020
* Fix schema.org dates to ISO-8601 * Revert date_to_xmlschema in <time> tag
kamil-adam
pushed a commit
to twocolumn/minimal-mistakes
that referenced
this pull request
Mar 15, 2021
* Fix schema.org dates to ISO-8601 * Revert date_to_xmlschema in <time> tag
kaitokikuchi
pushed a commit
to kaitokikuchi/kaitokikuchi.github.io
that referenced
this pull request
Sep 4, 2023
* Fix schema.org dates to ISO-8601 * Revert date_to_xmlschema in <time> tag
chukycheese
pushed a commit
to chukycheese/chukycheese.github.io
that referenced
this pull request
Sep 18, 2023
* Fix schema.org dates to ISO-8601 * Revert date_to_xmlschema in <time> tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix.
Summary
It seems that schema.org's date data type should be ISO-8601. So I updated
datePublishedanddateModifiedformat todate_to_xmlschema.