Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extension point to add scripts at the end of html page #2773

Closed
wants to merge 1 commit into from

Conversation

SebastienAndreo
Copy link

This is an enhancement or feature.

Summary

I have created an overridable file myscripts.html and include it at the end of default.html to be able to control more accurately some JS execution. I also made the customization point more visible by creating a folder custom in the _includes folder.

Context

It is sometimes useful to control the execution of some javascript being able to add them at
the end helped me to have the right rendering.

@iBug
Copy link
Collaborator

iBug commented Jan 1, 2021

Consider taking a look at #2116 and #2613 first. I think it's the recommended way to override scripts.html directly, but I could be wrong.

@tsmanner
Copy link
Contributor

tsmanner commented Feb 9, 2021

This sounds like a use for the after_footer_scripts config option. They're added at the end of scripts.html, which I think is equivalent to what this PR does, if the intent is to add <script src="/path/to/some/script.js"></script> tags to the site.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.

This pull request will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants