Add overlay_filter param to hero headers #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `overlay_filter` param lets you darken or otherwise filter the hero header picture to make the text content pop out more. You can use it by specifying the opacity (between 0 and 1) of a black overlay like so: ```yaml excerpt: "This post should display a **header with an overlay image**, if the theme supports it." header: overlay_image: unsplash-image-1.jpg overlay_filter: 0.5 # same as adding an opacity of 0.5 to a black background caption: "Photo credit: [**Unsplash**](https://unsplash.com)" cta_label: "More Info" cta_url: "https://unsplash.com" ``` Or if you want to do more fancy things, go full rgba: ```yaml excerpt: "This post should display a **header with an overlay image**, if the theme supports it." header: overlay_image: unsplash-image-1.jpg overlay_filter: rgba(255, 0, 0, 0.5) caption: "Photo credit: [**Unsplash**](https://unsplash.com)" cta_label: "More Info" cta_url: "https://unsplash.com" ```
| <div class="page__hero{% if page.header.overlay_color or page.header.overlay_image %}--overlay{% endif %}" | ||
| style="{% if page.header.overlay_color %}background-color: {{ page.header.overlay_color | default: 'transparent' }};{% endif %} {% if overlay_img_path %}background-image: url('{{ overlay_img_path }}');{% endif %}" | ||
| style="{% if page.header.overlay_color %}background-color: {{ page.header.overlay_color | default: 'transparent' }};{% endif %} {% if overlay_img_path %}background-image: {% if overlay_filter %}linear-gradient({{overlay_filter}}, {{overlay_filter}}), {% endif %}url('{{ overlay_img_path }}');{% endif %}" |
There was a problem hiding this comment.
Could you add spaces around the variable names eg. {{overlay_filter}} ~> {{ overlay_filter }} to stay consistent with how I reference them through out the rest of the theme?
|
Anything else? How do you handle documentation given it's in a different branch? |
|
Thanks and merged! On my todo list was to add an transparent black overlay by default, but your PR is much better as it offers more flexibility. Thanks again. |
|
No, thank you for an awesome project. |
cjmadsen
pushed a commit
to cjmadsen/cjmadsen.github.io
that referenced
this pull request
Dec 7, 2016
Add Slender
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
overlay_filterparam lets you darken or otherwise filter the hero header picture to make the text content pop out more.You can use it by specifying the opacity (between 0 and 1) of a black overlay like so:
Or if you want to do more fancy things, go full rgba: