Translate index page title #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @flohw |
cjmadsen
pushed a commit
to cjmadsen/cjmadsen.github.io
that referenced
this pull request
Dec 7, 2016
Add new template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently succeed to install and build my site with this theme (I got some issues with osx…). I have noticed that the page title of the index page was not translated.
Let me know if I can make other pull request like this or if it's preferable to "hard translate" in template inside of my project/repository.
Thanks
PS : I also have noticed a "no new line at end of file" diff but I don't know how to fix that. I am with osx and used vim to edit. I hope it's not a problem for you.