fix(includes/video): use https always #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
|
Updated to use HTTPs by default. My understanding is that HTTPS sites will not pass referrer info back to non-HTTPs. If so, oh well? 😺 |
RobinYu
added a commit
to RobinYu/robinyuuu.github.io
that referenced
this pull request
May 8, 2017
NicolasT
referenced
this pull request
in NicolasT/nicolast.github.io
May 30, 2017
* tag '4.4.1': (33 commits) Release 💎 4.4.1 Transition “hamburger” navicon on click to “X” navicon by adding `.close` to button - Close 969 Add link to comment New comment. (#968) New comment. (#967) Update CHANGELOG and history Sync `/docs` with root changes Update ui-text.yml (#958) fix(includes/video): use https always (#945) Update history Release 💎 4.4.0 Move SCSS partials to `/_sass/minimal-mistakes` for easier CSS customization Fixed link errors in docs (#946) Add closing `}` Fix `.masthead` and `.page__footer` overlapping full screen video elements. - Close #933 Update CHANGELOG and history Add ProTip about installing unreleased version on `master` Replace modified with last_modified_at (#930) Update CHANGELOG and history Add Lithuanian language/locale (#924) ... Conflicts: .github/CONTRIBUTING.md .github/ISSUE_TEMPLATE.md CHANGELOG.md README.md docs/_data/navigation.yml docs/_data/ui-text.yml docs/_docs/01-quick-start-guide.md docs/_docs/02-structure.md docs/_docs/03-installation.md docs/_docs/04-upgrading.md docs/_docs/05-configuration.md docs/_docs/06-overriding-theme-defaults.md docs/_docs/07-navigation.md docs/_docs/08-ui-text.md docs/_docs/09-authors.md docs/_docs/10-layouts.md docs/_docs/11-posts.md docs/_docs/12-pages.md docs/_docs/13-collections.md docs/_docs/14-helpers.md docs/_docs/15-utility-classes.md docs/_docs/16-stylesheets.md docs/_docs/17-javascript.md docs/_docs/18-history.md docs/_docs/19-contributing.md docs/_docs/20-docs-2-2.md docs/_docs/21-license.md docs/_includes/video docs/_layouts/default.html docs/_layouts/single.html docs/_layouts/splash.html docs/_pages/about.md docs/_pages/home.md docs/_pages/terms.md docs/_posts/2010-01-07-post-modified.md docs/_posts/2012-03-15-layout-header-overlay-image.md docs/_posts/2013-08-16-markup-syntax-highlighting.md docs/_posts/2016-09-21-gemified-theme-alpha.md docs/_posts/2016-10-06-gemified-theme-beta.md docs/_sass/minimal-mistakes/_animations.scss docs/_sass/minimal-mistakes/_archive.scss docs/_sass/minimal-mistakes/_base.scss docs/_sass/minimal-mistakes/_buttons.scss docs/_sass/minimal-mistakes/_footer.scss docs/_sass/minimal-mistakes/_forms.scss docs/_sass/minimal-mistakes/_masthead.scss docs/_sass/minimal-mistakes/_mixins.scss docs/_sass/minimal-mistakes/_navigation.scss docs/_sass/minimal-mistakes/_notices.scss docs/_sass/minimal-mistakes/_page.scss docs/_sass/minimal-mistakes/_reset.scss docs/_sass/minimal-mistakes/_sidebar.scss docs/_sass/minimal-mistakes/_syntax.scss docs/_sass/minimal-mistakes/_tables.scss docs/_sass/minimal-mistakes/_utilities.scss docs/_sass/minimal-mistakes/_variables.scss docs/_sass/minimal-mistakes/vendor/breakpoint/_breakpoint.scss docs/_sass/minimal-mistakes/vendor/breakpoint/_context.scss docs/_sass/minimal-mistakes/vendor/breakpoint/_helpers.scss docs/_sass/minimal-mistakes/vendor/breakpoint/_legacy-settings.scss docs/_sass/minimal-mistakes/vendor/breakpoint/_no-query.scss docs/_sass/minimal-mistakes/vendor/breakpoint/_parsers.scss docs/_sass/minimal-mistakes/vendor/breakpoint/_respond-to.scss docs/_sass/minimal-mistakes/vendor/breakpoint/_settings.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/_double.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/_query.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/_resolution.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/_single.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/_triple.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/double/_default-pair.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/double/_default.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/double/_double-string.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/resolution/_resolution.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/single/_default.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/triple/_default.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_animated.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_bordered-pulled.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_core.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_fixed-width.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_font-awesome.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_icons.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_larger.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_list.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_mixins.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_path.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_rotated-flipped.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_screen-reader.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_stacked.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_variables.scss docs/_sass/minimal-mistakes/vendor/magnific-popup/_magnific-popup.scss docs/_sass/minimal-mistakes/vendor/magnific-popup/_settings.scss docs/_sass/minimal-mistakes/vendor/susy/_su.scss docs/_sass/minimal-mistakes/vendor/susy/_susy.scss docs/_sass/minimal-mistakes/vendor/susy/_susyone.scss docs/_sass/minimal-mistakes/vendor/susy/susy/_su.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/_susy.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/_susyone.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_background.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_bleed.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_box-sizing.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_breakpoint-plugin.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_container.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_context.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_gallery.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_grids.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_gutters.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_isolate.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_margins.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_padding.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_rows.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_settings.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_span.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_validation.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_background.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_functions.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_grid.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_isolation.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_margin.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_media.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_padding.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_settings.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/_float.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/_shared.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/_support.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/float/_container.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/float/_end.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/float/_isolate.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/float/_span.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_background.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_container.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_direction.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_inspect.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_margins.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_output.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_padding.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_background.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_box-sizing.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_clearfix.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_prefix.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_rem.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_support.scss docs/_sass/minimal-mistakes/vendor/susy/susy/su/_grid.scss docs/_sass/minimal-mistakes/vendor/susy/susy/su/_settings.scss docs/_sass/minimal-mistakes/vendor/susy/susy/su/_utilities.scss docs/_sass/minimal-mistakes/vendor/susy/susy/su/_validation.scss docs/assets/css/main.scss docs/assets/js/main.min.js docs/assets/js/plugins/jquery.greedy-navigation.js minimal-mistakes-jekyll.gemspec test/_pages/terms.md test/_posts/2010-01-07-post-modified.md test/_posts/2012-03-15-layout-header-overlay-image.md test/_posts/2013-08-16-markup-syntax-highlighting.md
kkunapuli
pushed a commit
to kkunapuli/kkunapuli.github.io
that referenced
this pull request
May 30, 2019
makaroniame
added a commit
to makaroniame/makaroniame-old.github.io
that referenced
this pull request
May 18, 2022
jchwenger
pushed a commit
to jchwenger/jchwenger.github.io
that referenced
this pull request
May 5, 2023
koyumi0601
pushed a commit
to koyumi0601/koyumi0601.github.io
that referenced
this pull request
Jul 31, 2023
Hello everyone, this is my implementation for the copy button on the snippet (requested in mmistakes#924) The implementation is made 100% javascript as with or without a jekyll template modification you still have to execute some javascript code, and I consider it the best choice. the button only appears if the mouse is over it, to allow the entire line to be read the important CSS changes were made to make the copy button work even in the long code situation:  to avoid this:  Co-authored-by: Matt Wang <matt@matthewwang.me>
koyumi0601
pushed a commit
to koyumi0601/koyumi0601.github.io
that referenced
this pull request
Jul 31, 2023
This PR fixes three bugs: # first bug When revising my last PR mmistakes#1086 I realised a slight bug in the code-copy PR mmistakes#945 , my change to the css ignored a case. This PR is a hotfix and Before PR mmistakes#945:   After PR mmistakes#945:   Fix:   # second bug > @simonebortolin @mattxwang I'm trying to write some regression tests for this feature. > > If I use GitHub's copy button to copy the following plain text, it preserves all the spaces: > > ``` > 1 leading space > 2 leading spaces and 2 trailing spaces > 3 internal spaces > 4 trailing spaces > ``` > > Using the new copy button with the same text in this PR branch of JTD gives this: > > ``` > 1 leading space > 2 leading spaces and 2 trailing spaces > 3 internal spaces > 4 trailing spaces > ``` > > It appears that the leading space from line 1 has been removed, and inserted on all the other lines. Moreover, the 4 trailing spaces have been removed. > > BTW, mmistakes#924 didn't give a precise requirements spec, but mentioned the Microsoft docs UI; @mattxwang mentioned also the GitHub UI. It would be helpful to add a functional spec of what the JTD copy button is supposed to do, as a basis for regression tests. > > I'm not aiming at a rigorous test for the UI. Personally (using Safari at the default mag) I find the clipboard icon too small: it just looks like a box, and I can hardly see that there is a clip at the top. But I don't have a suggestion for a better icon. # third bug When I re-read the code after the second bug, I noticed a bug that it does not always select the text field to be copied correctly (in case there are also line numbers) is copied: ``` 1 2 3 4 # Ruby code with syntax highlighting and fixed line numbers using Liquid GitHubPages::Dependencies.gems.each do |gem, version| s.add_dependency(gem, "= #{version}") end ``` instead of ``` # Ruby code with syntax highlighting and fixed line numbers using Liquid GitHubPages::Dependencies.gems.each do |gem, version| s.add_dependency(gem, "= #{version}") end ``` Co-authored-by: Matt Wang <matt@matthewwang.me>
yesterz
pushed a commit
to yesterz/yesterz.github.io-test
that referenced
this pull request
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when served over https the vimeo link was failing. defer scheme used for video iframe src urls
realtive to the current protocol (e.g. http or https)
closes #944