Correct importance sampling as per d'Eon paper #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much--this looks great. Much appreciated! |
|
Happy to contribute. Thanks for the review! |
hubot
pushed a commit
to blender/blender
that referenced
this pull request
May 27, 2024
…ction Principled Chiang hair longitudinal importance sampling correction, according to the new pbrt fix here : mmp/pbrt-v3#256 Pull Request: https://projects.blender.org/blender/blender/pulls/115241
brechtvl
pushed a commit
to brechtvl/cycles
that referenced
this pull request
Jun 26, 2024
…ction Principled Chiang hair longitudinal importance sampling correction, according to the new pbrt fix here : mmp/pbrt-v3#256 Pull Request: https://projects.blender.org/blender/blender/pulls/115241
brechtvl
pushed a commit
to brechtvl/cycles
that referenced
this pull request
Jun 26, 2024
…ction Principled Chiang hair longitudinal importance sampling correction, according to the new pbrt fix here : mmp/pbrt-v3#256 Pull Request: https://projects.blender.org/blender/blender/pulls/115241
brechtvl
pushed a commit
to brechtvl/cycles
that referenced
this pull request
Jun 26, 2024
…ction Principled Chiang hair longitudinal importance sampling correction, according to the new pbrt fix here : mmp/pbrt-v3#256 Pull Request: https://projects.blender.org/blender/blender/pulls/115241
brechtvl
pushed a commit
to brechtvl/cycles
that referenced
this pull request
Jun 27, 2024
…ction Principled Chiang hair longitudinal importance sampling correction, according to the new pbrt fix here : mmp/pbrt-v3#256 Pull Request: https://projects.blender.org/blender/blender/pulls/115241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #121, the sampling of the longitudinal component of the hair BSDF is different from the strategy mentioned in the original d'Eon paper. I have corrected the sampling strategy by rotating the outgoing vector due to the cuticle scale tilt before sampling the longitudinal component.