refactored #12
refactored #12
Conversation
docs/scripts/buildApi.ts
Outdated
| const componentName = path.basename(component.filename).replace(/\.js$/, ''); | ||
| const cssFilename = `../data/css/${camelCaseToKebabCase(componentName)}-css.js`; | ||
| try { | ||
| const cssModule = require(cssFilename); |
There was a problem hiding this comment.
I'd just read the json with fs-extra. require is slowly getting replace and with require we have to rely on webpack.
There was a problem hiding this comment.
Converted the file to .json and used readFileSync. Should we merge this on the main branch? Edit: merged this one on the main branch, we can continue discussion there to be more visible.
These classes are still used in the theme overrides as keys, it is not misleading information. We just don't support the |
How is it not misleading to mention the |
The classes keys are still used as keys in the styleOverrides inside the theme. Where am I mentioning the classes prop? |
Move picker sources into lab (#4) Update README.md [DatePicker] Refactor pickers tests to testing-library and mocha (#5) [TimePicker] Migrate tests to testing library (#8) [DateTimePicker] Migrate tests (#9) Fix all pickers linter errors (#10) Fix all circular dependencies (#11) * Fix all circular dependencies * Enable mocha eslint rules for typescript tests [test] The last step to a green CI (#15) Migrate pickers docs (#12) Downgrade to withStyles for pickers sources (#16) Add public api exports for pickers components (#17) Consolidate component namespace and theme augmentation (#18) Describe conformance for pickers sub-components (#19) Autogenerate proptypes for typescript sources (#20) Proper build output (#21) Clear migration artifacts (#23) Eslint rule for lower-case test name convention (#24) DateRangePicker (#25) yarn deduplicate Remove GridListTile [DateTimePicker] Fix migration unit tests Fix types Fix typescript types migration issues Fix yarn lerna build (#33) Fix karma tests use window.Touch for CI karma tests Remove more outdated diff noise (#34) Replace not valid formats with valid ISO strings Try to fix CI touch tests Skip tests if Touch events are not supported Fix merge conflicts Actually type-check Fix safari tests Remove lowercase test name rule The casing is up to the test author. We're not the grammar police in tests. Fix lint Format Remove overzealous eslint-disable* Debug failing tests Better debugging Timezones are fun was isoString th efix? Let's find out what's failing and then skip it Branch for safari Skip DateRangePicker in browsers review Matt's review Co-authored-by: Matt <github@nospam.33m.co> format docs:i18n
Addressing comment mui#23370 (review)