Fix GH-187 Temporary fix for getting incorrect thread ID caused by iPhone bug #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l synchronization processing.
SakiTakamachi
commented
Sep 18, 2023
| if ($threadId === null && $inReplyTo !== null) { | ||
|
|
||
| $threadId = null; | ||
| if ($firstReference !== null) { |
There was a problem hiding this comment.
The processing around this can be written in one line, but it is written this way for readability.
|
@mnapoli |
mnapoli
reviewed
Sep 18, 2023
|
I'm fine merging this and giving it a try! I added a small suggestion for future maintenance. |
Co-authored-by: Matthieu Napoli <matthieu@mnapoli.fr>
|
Thank you for confirmation! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see here for details.
#187
To fundamentally solve this problem, Apple has to fix a bug in the mailer.
I am proposing this change as temporary rather than permanent.
Regards.
Emails that are not displayed in "externals" can be viewed in "internals" mailboxes if we want to see them, so if you decide that this modification is unnecessary, I will follow it.