Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI after upstream changes #1071

Merged
merged 3 commits into from
Sep 30, 2022
Merged

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Sep 29, 2022

PR Description

goes together with

to fix the CI

identified in

Also fixes a bug with _orig_units, because the format has changed upstream in:

ready for merge after the MNE-Python PR above has been merged.

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@sappelhoff sappelhoff changed the title fix CI after upstream changes to handling of EEG coords read from headers fix CI after upstream changes Sep 29, 2022
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #1071 (e8c0fc7) into main (6624276) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1071   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files          24       24           
  Lines        3845     3845           
=======================================
  Hits         3661     3661           
  Misses        184      184           
Impacted Files Coverage Δ
mne_bids/write.py 97.29% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hoechenberger hoechenberger merged commit 1a50295 into mne-tools:main Sep 30, 2022
@hoechenberger
Copy link
Member

Thanks @sappelhoff

@sappelhoff sappelhoff deleted the fix/coords/cnt branch September 30, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants