Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: Use explicitly public namespaces #1165

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Aug 22, 2023

In mne-tools/mne-python#11903 we're trying to make some mne/io stuff private. This changes mne-bids to use the explicitly public API

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #1165 (90d99a0) into main (1a195dc) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1165   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files          40       40           
  Lines        8655     8655           
=======================================
  Hits         8450     8450           
  Misses        205      205           
Files Changed Coverage Δ
mne_bids/dig.py 98.59% <100.00%> (ø)
mne_bids/read.py 95.89% <100.00%> (ø)
mne_bids/utils.py 94.92% <100.00%> (ø)
mne_bids/write.py 97.40% <100.00%> (ø)

@agramfort agramfort merged commit b5fb303 into mne-tools:main Aug 22, 2023
@larsoner larsoner deleted the public branch August 22, 2023 13:56
@sappelhoff
Copy link
Member

@drammock
Copy link
Member

@larsoner maybe of interest to you: https://github.com/sappelhoff/mne-bids/actions/runs/5946959859/job/16128317716 (CI failure)

The error on that CI run seems to not have the changes in this PR?

https://github.com/sappelhoff/mne-bids/actions/runs/5946959859/job/16128317716#step:16:60

still says

from mne.io.pick import pick_types

@larsoner
Copy link
Member Author

@sappelhoff
Copy link
Member

sorry for the noise and thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants