-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: Use explicitly public namespaces #1165
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1165 +/- ##
=======================================
Coverage 97.63% 97.63%
=======================================
Files 40 40
Lines 8655 8655
=======================================
Hits 8450 8450
Misses 205 205
|
@larsoner maybe of interest to you: https://github.com/sappelhoff/mne-bids/actions/runs/5946959859/job/16128317716 (CI failure) |
The error on that CI run seems to not have the changes in this PR? https://github.com/sappelhoff/mne-bids/actions/runs/5946959859/job/16128317716#step:16:60 still says from mne.io.pick import pick_types |
Indeed that's a run on the You need to update your |
sorry for the noise and thanks for the explanation. |
In mne-tools/mne-python#11903 we're trying to make some mne/io stuff private. This changes mne-bids to use the explicitly public API