-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: Use hatchling as build backend #1204
Changes from 9 commits
fdbf6eb
0a755ff
4f8940e
246e3b5
94ece07
5bb7571
7163741
715dd71
75f61df
e4edda3
cd5542a
3800913
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
node: $Format:%H$ | ||
node-date: $Format:%cI$ | ||
describe-name: $Format:%(describe:tags=true,match=*[0-9]*)$ | ||
ref-names: $Format:%D$ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
.git_archival.txt export-subst |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[build-system] | ||
requires = ["setuptools", "wheel"] | ||
build-backend = "setuptools.build_meta" | ||
requires = ["hatchling", "hatch-vcs"] | ||
build-backend = "hatchling.build" | ||
|
||
[project] | ||
name = "mne-bids" | ||
|
@@ -40,6 +40,7 @@ classifiers = [ | |
] | ||
scripts = { mne_bids = "mne_bids.commands.run:main" } | ||
dependencies = ["mne>=1.5", "numpy>=1.21.2", "scipy>=1.7.1"] | ||
|
||
[project.optional-dependencies] | ||
# Variants with dependencies that will get installed on top of those listed unter | ||
# project.dependencies | ||
|
@@ -57,14 +58,7 @@ full = [ | |
] | ||
|
||
# Dependencies for running the test infrastructure | ||
test = [ | ||
"mne_bids[full]", | ||
"pytest", | ||
"pytest-cov", | ||
"pytest-sugar", | ||
"check-manifest", | ||
"ruff", | ||
] | ||
test = ["mne_bids[full]", "pytest", "pytest-cov", "pytest-sugar", "ruff"] | ||
|
||
# Dependencies for building the documentation | ||
doc = [ | ||
|
@@ -80,7 +74,7 @@ doc = [ | |
"mne-nirs @ https://github.com/mne-tools/mne-nirs/archive/refs/heads/main.zip", | ||
"seaborn", | ||
"openneuro-py", | ||
"defusedxml", # for reading BrainVision montages: `examples/convert_eeg_to_bids.py` | ||
"defusedxml", # for reading BrainVision montages: `examples/convert_eeg_to_bids.py` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this is mistake or by design? if by design, why? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My linter adds this automatically... but I can change it Otherwise number of spaces before an inline comment in TOML is just 1 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Btw the linter I use comes with the Even Better TOML extension for VS Code Very helpful tool really |
||
] | ||
|
||
# Dependencies for developer installations | ||
|
@@ -94,14 +88,24 @@ dev = ["mne_bids[test,doc,full]", "pre-commit"] | |
"Forum" = "https://mne.discourse.group/" | ||
"Source Code" = "https://github.com/mne-tools/mne-bids" | ||
|
||
[tool.setuptools.packages.find] | ||
where = ["."] | ||
include = ["mne_bids"] | ||
exclude = ["tests"] | ||
namespaces = false | ||
[tool.hatch.metadata] | ||
allow-direct-references = true # allow specifying URLs in our dependencies | ||
|
||
[tool.hatch.build] | ||
exclude = [ | ||
"/.*", | ||
"**/tests", | ||
"/paper", | ||
"/examples", | ||
"/doc", | ||
"/Makefile", | ||
"/CITATION.cff", | ||
"/CONTRIBUTING.md", | ||
] | ||
|
||
[tool.setuptools.dynamic] | ||
version = { attr = "mne_bids.__version__" } | ||
[tool.hatch.version] | ||
source = "vcs" | ||
raw-options = { version_scheme = "release-branch-semver" } | ||
|
||
[tool.ruff] | ||
select = ["E", "F", "W", "D", "I"] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in what ways does it affect users who build and install mne-bids from source? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build process is simply different now. Maybe it should be phrased differently? No user intervention is required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure it should be in the release notes then🤔 usually we skip "infrastructure changes without effect on the user", don't we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a Code Health section like we have in MNE-BIDS-Pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MS does the same for the VS Code Python extension