Simplify authors and copyright in all .py files (and make consistent) #1267
Conversation
examples/create_bids_folder.py
Outdated
| @@ -53,3 +54,6 @@ | |||
| subject="01", session="mysession", datatype="meg", root="path/to/project" | |||
| ).mkdir() | |||
| print(bids_path.directory) | |||
|
|
|||
| # clean up | |||
| shutil.rmtree(bids_path) | |||
There was a problem hiding this comment.
this would otherwise create an annoying directory when running tests locally
| @@ -204,7 +204,7 @@ jobs: | |||
| - name: Install MNE (previous stable) | |||
| if: matrix.mne-version == 'mne-prev-stable' | |||
| run: | | |||
| git clone --single-branch --branch maint/1.5 https://github.com/mne-tools/mne-python.git | |||
| git clone --single-branch --branch maint/1.6 https://github.com/mne-tools/mne-python.git | |||
There was a problem hiding this comment.
why did we opt to not get this from PyPI?
There was a problem hiding this comment.
we need the full repo, including stuff that's not shipped in the dist
| @@ -6,6 +6,10 @@ | |||
| https://doughellmann.com/blog/2010/05/09/defining-custom-roles-in-sphinx/ | |||
|
|
|||
| """ | |||
|
|
|||
There was a problem hiding this comment.
shouldn't this go to the very very top of every file?
There was a problem hiding this comment.
I think it should go right below the module docstrings 🤔 that's how it's in sklearn, too, see: https://github.com/scikit-learn/scikit-learn/blob/main/sklearn/decomposition/_base.py
There was a problem hiding this comment.
ok then! i still find it odd, i thought its supposed to be a header 😅
There was a problem hiding this comment.
The guideline says "near the beginning" (https://www.bestpractices.dev/en/projects/7783?criteria_level=2)
The project MUST include a license statement in each source file. This MAY be done by including the following inside a comment near the beginning of each file:
:-)
I am going ahead and will merge this now. We can always change it later. Thanks!
There was a problem hiding this comment.
yes all good! thanks for the work!!!
PR Description
Merge checklist
Maintainer, please confirm the following before merging.
If applicable: