-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] fix loading without age information / single-column .tsv #912
Conversation
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @skjerns - would you mind adding a small test here? --> https://github.com/mne-tools/mne-bids/blob/main/mne_bids/tests/test_report.py
also: it's just a small fix, but could you add an entry to the changelog? https://github.com/mne-tools/mne-bids/blob/main/doc/whats_new.rst
It'll also showcase your first PR contribution to mne-bids :-)
Codecov Report
@@ Coverage Diff @@
## main #912 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 23 23
Lines 3488 3488
=======================================
Hits 3306 3306
Misses 182 182
Continue to review full report at Codecov.
|
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something seems to have gone wrong with rebasing and/or merging main
into this PR 🤔 There are lots of changes that shouldn't be changes
damn, I might have pulled from the wrong main. I'll tried to fix it - is it fine now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks much better now!
Whoops, CI failing now, can you have a look? If you're busy, I might be able to take over tomorrow |
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
thx @skjerns |
PR Description
When loading participants.tsv with only a single column (only participant ids),
p_age
is empty, and can therefore not be created. See also #891 . This simple fix resolves this problem.Merge checklist
Maintainer, please confirm the following before merging: