Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: try fix cis #29

Merged
merged 13 commits into from
Apr 29, 2024
Merged

MAINT: try fix cis #29

merged 13 commits into from
Apr 29, 2024

Conversation

alexrockhill
Copy link
Collaborator

Fix the CI failures

@alexrockhill
Copy link
Collaborator Author

alexrockhill commented Apr 26, 2024

Ok @larsoner , sorry I'm a bit stuck on this one too, do you know how to increase the read timeout on MNE dataset fetching? (It's during fetch_fsaverage)

image

@larsoner
Copy link
Member

No I haven't hit an issue... you could look to see if there is some global var but from the looks of it we use pooch so you'd have to see what their default is etc.

Also in MNE-Python we download all datasets before running any examples. It can help clean up the captured output and more accurately reflect the example timing.

@alexrockhill
Copy link
Collaborator Author

It looks like pooch hardcodes it, I will trying downloading before

@alexrockhill
Copy link
Collaborator Author

alexrockhill commented Apr 26, 2024

Hey @larsoner sorry to bug you again but I was trying to read this thread sphinx-doc/sphinx#12300 and suppress the warning but I couldn't figure out how to get the scraper to pickle like it's done in mne-python, mind pointing me in the right direction?

@larsoner
Copy link
Member

The easy workaround on CIs is mne-tools/mne-python#12552 (pin sphinx) or https://github.com/mne-tools/mne-python/pull/12548/files#diff-e170e9a7d787c21095c6c11bb25f0f1ff0294a42a46d45ba6fb5ed794e457624R809 (ignore the warning). The correct long-term fix is mne-tools/mne-python#12574 but requires latest SG master (but should be released next week)

@alexrockhill
Copy link
Collaborator Author

I tried to implement the long term fix, maybe I just need the latest sg for the scapers to get recognized, I'll check

@alexrockhill
Copy link
Collaborator Author

Ok by you @larsoner? Finally everything passes

Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a misleading comment LGTM

Comment on lines +45 to +46
# TO DO: sphinx-gallery main -> stable on 0.17 release
pip install --upgrade PyQt6!=6.6.0 "PyQt6-Qt6!=6.6.0,!=6.7.0" git+https://github.com/sphinx-gallery/sphinx-gallery.git pydata-sphinx-theme numpydoc scikit-learn nilearn mne-bids autoreject pyvista memory_profiler sphinxcontrib.bibtex sphinxcontrib.youtube darkdetect qdarkstyle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG 0.16 is out now which should work for you already. So you can either revert this entirely or just remove the comment (as it should also be safe to use the SG master development branch)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah my bad! I'll take it out in the #27

@alexrockhill alexrockhill merged commit 5e2aaa4 into mne-tools:main Apr 29, 2024
13 checks passed
@alexrockhill alexrockhill deleted the cis branch April 29, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants