-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: try fix cis #29
Conversation
Ok @larsoner , sorry I'm a bit stuck on this one too, do you know how to increase the read timeout on MNE dataset fetching? (It's during |
No I haven't hit an issue... you could look to see if there is some global var but from the looks of it we use Also in MNE-Python we download all datasets before running any examples. It can help clean up the captured output and more accurately reflect the example timing. |
It looks like pooch hardcodes it, I will trying downloading before |
Hey @larsoner sorry to bug you again but I was trying to read this thread sphinx-doc/sphinx#12300 and suppress the warning but I couldn't figure out how to get the scraper to pickle like it's done in |
The easy workaround on CIs is mne-tools/mne-python#12552 (pin sphinx) or https://github.com/mne-tools/mne-python/pull/12548/files#diff-e170e9a7d787c21095c6c11bb25f0f1ff0294a42a46d45ba6fb5ed794e457624R809 (ignore the warning). The correct long-term fix is mne-tools/mne-python#12574 but requires latest SG |
I tried to implement the long term fix, maybe I just need the latest sg for the scapers to get recognized, I'll check |
Ok by you @larsoner? Finally everything passes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a misleading comment LGTM
# TO DO: sphinx-gallery main -> stable on 0.17 release | ||
pip install --upgrade PyQt6!=6.6.0 "PyQt6-Qt6!=6.6.0,!=6.7.0" git+https://github.com/sphinx-gallery/sphinx-gallery.git pydata-sphinx-theme numpydoc scikit-learn nilearn mne-bids autoreject pyvista memory_profiler sphinxcontrib.bibtex sphinxcontrib.youtube darkdetect qdarkstyle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SG 0.16 is out now which should work for you already. So you can either revert this entirely or just remove the comment (as it should also be safe to use the SG master
development branch)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah my bad! I'll take it out in the #27
Fix the CI failures