-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Sign Windows binary inplace #183
Conversation
I vaguely recall somewhere in the conda or napari docs saying that pinning versions can speed up resolution. Given that resolution took ~30 minutes on macOS and we can get our list of outdated dependencies using |
By pinning:
|
Amazing improvements! I'm just worried we might run into dependency resolution errors someday if we start pinning too many things. But as long as it works, let's keep it! |
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
I did in 545caad actually but it was fairly easy to resolve. Agreed we should undo it later if needed. FWIW it also gives us some indication of when packages are not all up to date across all architectures due to conflicts, which is otherwise hidden/implicit. In this case currently it's only fsleyes on windows and vtk on Mac non-ARM. |
We should be able to sign inplace now: SSLcom/actions-codesigner#1
This PR should do it, but I expect some timeout failures we'll need to debug before 1.4. No idea why it took so long on a couple of platforms when I was testing in an isolated branch in this repo, we'll see if it happens again.