Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Add tests for setuptools_scm versions, fix mne-qt-browser #188

Merged
merged 4 commits into from
May 17, 2023

Conversation

larsoner
Copy link
Member

To help check mne-tools/mne-qt-browser#165

Eventually we could probably assert actual version numbers based on our pinning file and such. But for now this is good enough I think

Should fail until conda-forge/mne-qt-browser-feedstock#24 is in and CDNs update

@hoechenberger
Copy link
Member

hoechenberger commented May 17, 2023

I don't understand why we'd need this – shouldn't dependency resolution fail if we cannot get the package version that we requested in the recipe? Or has this to do with setuptools-scm?

Edit: Ok, I read up on the linked issue. I'm okay with having this here as a temporary check until we start testing for the actual version numbers we put in the recipe, like you suggested

@larsoner
Copy link
Member Author

I'm okay with having this here as a temporary check until we start testing for the actual version numbers we put in the recipe, like you suggested

Might as well be permanent -- conda's package version numbers are not guaranteed to match the actual module.__version__, so we might as well check the setuptools_scm packages that we have to make sure that they do.

@larsoner
Copy link
Member Author

Will merge and cut a 1.4.0_1 release since mne-qt-browser Epochs browsing is broken on 1.4.0_0

@larsoner larsoner enabled auto-merge (squash) May 17, 2023 18:30
@larsoner larsoner changed the title TST: Add tests for setuptools_scm versions BUG: Add tests for setuptools_scm versions, fix mne-qt-browser May 17, 2023
@larsoner larsoner merged commit 148cc76 into mne-tools:main May 17, 2023
@larsoner larsoner deleted the ver branch May 17, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants