Build and test installers natively on Apple Silicon M1 (macOS 14) #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoechenberger
changed the title
hoechenberger
commented
Feb 18, 2024
.github/workflows/build.yml
Outdated
| # include: | ||
| # - os: macos-11 | ||
| # arch: arm64 | ||
| os: [macos-11, macos-12, macos-13, macos-14] |
There was a problem hiding this comment.
also added macOS-13 here (runs on Intel; macos-14 always runs on M1)
hoechenberger
commented
Feb 18, 2024
Comment on lines
-87
to
-90
| if [[ "$MNE_CROSSCOMPILE_ARCH" == "arm64" ]]; then | ||
| echo "PLATFORM_ARG=--platform=osx-arm64" >> $GITHUB_ENV | ||
| echo "EXE_ARG=--conda-exe=${CONDA_PREFIX}/standalone_conda/conda.exe" >> $GITHUB_ENV | ||
| fi |
There was a problem hiding this comment.
we shouldn't need this anymore, but I'm not sure about the implications
… installer Python
hoechenberger
changed the title
|
@larsoner I think this is good to go |
|
Awesome @hoechenberger ! |
larsoner
added a commit
to larsoner/mne-installers
that referenced
this pull request
Feb 21, 2024
* upstream/main: [pre-commit.ci] pre-commit autoupdate (mne-tools#251) Build and test installers natively on Apple Silicon M1 (macOS 14) (mne-tools#249) [pre-commit.ci] pre-commit autoupdate (mne-tools#247)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@larsoner I know you love this stuff ;)
I just wanted to get us started
We need to change
extract_version.sh, I think you have a much better understanding of what needs to be done than I do. Please do feel free to take over if you want!!FYI macOS-14 exclusively runs on M1, while earlier macOS runners exclusively run on Intel. This just to explain why I removed the architecture identifier from the job matrix in favor of just having the OS version listed.
Closes #248