Skip to content

Commit

Permalink
fix: change ci param to errorbar in sns-catplot (#524)
Browse files Browse the repository at this point in the history
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
  • Loading branch information
Busato and larsoner authored Oct 12, 2023
1 parent 050b2a2 commit a900d8e
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
2 changes: 2 additions & 0 deletions doc/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ To install a specific version of the library you would run ``pip install mne-nir
v0.6.dev0
---------

* Changed ci param to errorbar in sns-catplot functions. By `Nicolas Busato`_.
* Fix bug in SNIRF writer that caused incorrect duration to be written to file. By `Robert Luke`_.
* Add option to export montage location in SNIRF using the landmarkLabels field. By `Robert Luke`_.
* Fix continuous integration issues and update test infrastructure. By `Florin Pop`_.
Expand Down Expand Up @@ -197,3 +198,4 @@ Enhancements
.. _Samuel Powell: https://github.com/samuelpowell
.. _Johann Benerradi: https://github.com/HanBnrd
.. _Florin Pop: https://github.com/florin-pop
.. _Nicolas Busato: https://github.com/Busato
4 changes: 2 additions & 2 deletions examples/general/plot_12_group_glm.py
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ def individual_analysis(bids_path, ID):
grp_results = df_roi.query("Condition in ['Control', 'Tapping_Left', 'Tapping_Right']")
grp_results = grp_results.query("Chroma in ['hbo']")

sns.catplot(x="Condition", y="theta", col="ID", hue="ROI", data=grp_results, col_wrap=5, ci=None, palette="muted", height=4, s=10)
sns.catplot(x="Condition", y="theta", col="ID", hue="ROI", data=grp_results, col_wrap=5, errorbar=None, palette="muted", height=4, s=10)


# %%
Expand Down Expand Up @@ -372,7 +372,7 @@ def individual_analysis(bids_path, ID):

df = statsmodels_to_results(roi_model)

sns.catplot(x="Condition", y="Coef.", hue="ROI", data=df.query("Chroma == 'hbo'"), ci=None, palette="muted", height=4, s=10)
sns.catplot(x="Condition", y="Coef.", hue="ROI", data=df.query("Chroma == 'hbo'"), errorbar=None, palette="muted", height=4, s=10)


# %%
Expand Down
2 changes: 1 addition & 1 deletion examples/general/plot_16_waveform_group.py
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ def individual_analysis(bids_path):
# For this reason, fNIRS is most appropriate for detecting changes within a
# single ROI between conditions.

sns.catplot(x="Condition", y="Value", hue="ID", data=df.query("Chroma == 'hbo'"), ci=None, palette="muted", height=4, s=10)
sns.catplot(x="Condition", y="Value", hue="ID", data=df.query("Chroma == 'hbo'"), errorbar=None, palette="muted", height=4, s=10)


# %%
Expand Down
1 change: 0 additions & 1 deletion mne_nirs/tests/test_examples.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ def examples_path():
@pytest.mark.filterwarnings('ignore:No bad channels to interpolate.*:')
@pytest.mark.filterwarnings('ignore:divide by zero encountered.*:')
@pytest.mark.filterwarnings('ignore:invalid value encountered.*:')
@pytest.mark.filterwarnings("ignore:.*\n\nThe `ci` parameter is deprecated.*:")
@pytest.mark.skipif(
sys.platform.startswith('win'), reason='Unstable on Windows')
@pytest.mark.examples
Expand Down

0 comments on commit a900d8e

Please sign in to comment.