[FIX] Make report context manager stop swallowing exceptions (#6614)

Make report context manager stop swallowing exceptions

doc/whats_new.rst

@@ -97,6 +97,8 @@ Bug
 
 - Fix :func:`mne.io.read_raw_brainvision` not handling ``Event`` markers created by PyCorder correctly by `Richard Höchenberger`_
 
+- Fix :class:`mne.Report` silently suppressing exceptions when used as a context manager by `Marijn van Vliet`_
+
 API
 ~~~
 

mne/report.py

@@ -1617,7 +1617,6 @@ def __exit__(self, type, value, traceback):
         """Save the report when leaving the context block."""
         if self._fname is not None:
             self.save(self._fname, open_browser=False, overwrite=True)
-        return self
 
     @verbose
     def _render_toc(self, verbose=None):

mne/tests/test_report.py

@@ -343,6 +343,11 @@ def test_open_report():
     pytest.raises(ValueError, open_report, hdf5, subjects_dir='foo')
     open_report(hdf5, subjects_dir=subjects_dir)  # This should work
 
+    # Check that the context manager doesn't swallow exceptions
+    with pytest.raises(ZeroDivisionError):
+        with open_report(hdf5, subjects_dir=subjects_dir) as report:
+            1 / 0
+
 
 def test_remove():
     """Test removing figures from a report."""