Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Remove deprecation for kind #11304

Merged
merged 10 commits into from
Nov 4, 2022
Merged

MAINT: Remove deprecation for kind #11304

merged 10 commits into from
Nov 4, 2022

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Nov 3, 2022

Post-release deprecation resolution

@drammock there is a remaining one in mne/viz/topomap.py, feel free to take care of it by pushing commits here or by opening a separate PR

@drammock
Copy link
Member

drammock commented Nov 3, 2022

@larsoner there were a TON of things to remove; thanks for noticing / reminding that I forgot to do this after release.

@@ -3081,14 +2972,6 @@ def plot_regression_weights(
%(ch_type_topomap)s
%(sensors_topomap)s
%(show_names_topomap)s

.. versionadded:: 1.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nb: this removal is not a mistake; the whole function was added in 1.2 so no need to point out that this param was also added then.

@mmagnuski
Copy link
Member

Just BTW - why was it decided to remove vmin and vmax and use vlims for topomaps? As long as I remember I used vmin and vmax in mne and I don't think I ever encountered vlims in topomap plotting.

@drammock
Copy link
Member

drammock commented Nov 4, 2022

Just BTW - why was it decided to remove vmin and vmax and use vlims for topomaps?

There are some topomap functions where vlim='joint' is an option (to compute vmin/vmax automatically and have it be the same for all subplots). I think plot_projs_topomap was the original use case for this. Since the goal was to standardize the param names across all topomap-generating funcs/methods, switching them all to vlim was the simplest way.

@mmagnuski
Copy link
Member

Ok, I get it now :)

@drammock drammock enabled auto-merge (squash) November 4, 2022 15:57
@drammock drammock merged commit 0ec28e9 into mne-tools:main Nov 4, 2022
@larsoner larsoner deleted the dep branch November 4, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants