-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Remove deprecation for kind #11304
Conversation
@larsoner there were a TON of things to remove; thanks for noticing / reminding that I forgot to do this after release. |
@@ -3081,14 +2972,6 @@ def plot_regression_weights( | |||
%(ch_type_topomap)s | |||
%(sensors_topomap)s | |||
%(show_names_topomap)s | |||
|
|||
.. versionadded:: 1.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nb: this removal is not a mistake; the whole function was added in 1.2 so no need to point out that this param was also added then.
Just BTW - why was it decided to remove |
There are some topomap functions where |
Ok, I get it now :) |
Post-release deprecation resolution
@drammock there is a remaining one in
mne/viz/topomap.py
, feel free to take care of it by pushing commits here or by opening a separate PR