Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Fix bug with arm64 #11865

Merged
merged 5 commits into from
Aug 7, 2023
Merged

FIX: Fix bug with arm64 #11865

merged 5 commits into from
Aug 7, 2023

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Aug 7, 2023

Going to see if the "slow rendering" was actually a Numba problem as well as fixing recent CircleCI failures on main

@@ -62,7 +62,7 @@ Bugs
- Allow int-like for the argument ``id`` of `~mne.make_fixed_length_events` (:gh:`11748` by `Mathieu Scheltienne`_)
- Fix bugs with :mod:`mne.decoding` classes (:gh:`11846` by `Eric Larson`_):
- :class:`mne.decoding.ReceptiveField` now sets ``rf.fit_intercept_`` during ``fit()`` rather than overwriting ``rf.fit_intercept``
- :class:`mne.decoding.SlidingEstimator` now returns the same ``dtype`` as ``X`` (usually ``float64``) in ``sl.predict(X)`` rather than always returning ``int``
- :class:`mne.decoding.SlidingEstimator` now returns the same ``dtype`` as ``X`` (usually ``float64``) in ``sl.transform(X)`` rather than always returning ``int``

This comment was marked as outdated.

@larsoner
Copy link
Member Author

larsoner commented Aug 7, 2023

... couldn't resist the temptation to add yamllint to pre-commit while I was at it. TL;DR there is that we have some bad indentations that I've ignored for now, but plan to merge this PR, fix those in a different PR, then add the commit that fixed things to git-revs-ignore. This could be done via rebase+merge but I think it'll be easier just to do in separate PRs so we don't have to mess with our repo merge settings and worry if the branch is up to date so rebase+merge doesn't change the commit number, etc. I "just" have to remember in some follow-up PR to add the squash+merged PR's commit to the revs-ignore, which seems okay -- if I forget the cost is very low, and can easily be fixed later when actually looking at the blame someday.

@@ -1,4 +1,4 @@
on: [status]
on: [status] # yamllint disable-line rule:truthy
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun fact -- "on" is truthy and actually you can have truthy keys in YAML. So a slightly more correct alternative here would be to change this to "on": .... But this isn't how I've ever seen a .github/workflows example and it's not how they do it in their docs. So it seemed like the safest option was an inline ignore. See also adrienverge/yamllint#430

@larsoner larsoner enabled auto-merge (squash) August 7, 2023 14:17
@larsoner larsoner merged commit 86dd11d into mne-tools:main Aug 7, 2023
21 checks passed
snwnde pushed a commit to snwnde/mne-python that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants