Bug channel annot merge #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Preventing merge between 2 annotations if at least one has a channe-specific annotation works for me. That's a good rule to start with and it can be changed later.
I am however greeted with this error when dragging a channel-specific annotation inside another one:
Traceback (most recent call last):
File "/home/scheltie/git/mscheltienne/mne-qt-browser/mne_qt_browser/_pg_figure.py", line 4645, in _region_changed
idx = self._get_onset_idx(region.old_onset)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/scheltie/git/mscheltienne/mne-qt-browser/mne_qt_browser/_pg_figure.py", line 4639, in _get_onset_idx
idx = np.where(self.mne.inst.annotations.onset == onset)[0][0]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^
IndexError: index 0 is out of bounds for axis 0 with size 0
screncast-issue.webm
|
@mscheltienne I just checked and this is a bug even for general annotations. I can fix this in this or another PR. Untitled.mov |
|
Feel free to fix in this PR |
larsoner
reviewed
Aug 12, 2024
There was a problem hiding this comment.
@nmarkowitz can you verify that this works properly, and then add unit tests? Then we should be able to merge!
mne_qt_browser/_pg_figure.py
Outdated
| logger.debug(f"New {self.description} region: {onset:.2f} - {offset:.2f}") | ||
| # remove overlapping regions | ||
| for region in overlapping_regions: | ||
| # region.removeSingleChannelAnnots.emit(region) |
mscheltienne
approved these changes
Aug 16, 2024
|
@larsoner this one is ready to be merged |
larsoner
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Example: Fixes #1234.
What does this implement/fix?
Fix issues when combining channel-based annotations with another annotation.
Additional information
Channel-based annotation can not merge with any other annotation.