Mnes 1186 add sqlite db #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
hofermo,
JonathanXITASO,
NilsXitaso,
pawel-baran-se,
XAlinaGS and
Xmilofranke
NilsXitaso
approved these changes
Aug 26, 2024
# Description New settings page layout with vertical tabs. ## Type of change Please delete options that are not relevant. - [ ] New feature (non-breaking change which adds functionality) # Checklist: - [ ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix or my feature works - [ ] New and existing tests pass locally with my changes - [ ] My changes contain no console logs
Xmilofranke
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Don't we also need endpoints for updating and deleting connections?
There was a problem hiding this comment.
Yes, will add them as soon as I need them.
Xmilofranke
reviewed
Aug 26, 2024
| @@ -20,6 +20,8 @@ export const deMnestix = { | |||
| idStructure: 'ID Struktur', | |||
| idStructureExplanation: | |||
| 'Definieren Sie, wie Ihre IDs aussehen sollen. Dies ist eine Basis-Einstellung, die für individuelle Importe angepasst werden kann.', | |||
| mnestixConnections: 'Mnestix Quellen', | |||
| mnestixConnectionsExplanation: 'Definieren Sie, welche Daten Quellen verwendet werden sollen.', | |||
There was a problem hiding this comment.
Not related to this PR, but do we really want to use the formal "Sie" instead of just "Definiere, welche [...]"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added SQLite database and schema + seeding with prisma.
Type of change
Please delete options that are not relevant.
Checklist: