Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix set save pos at end #12

Closed
wants to merge 7 commits into from
Closed

Fix set save pos at end #12

wants to merge 7 commits into from

Conversation

piz-ewing
Copy link

fix #5

mnezerka
mnezerka requested changes Jan 18, 2023
View reviewed changes
Copy link
Owner

@mnezerka mnezerka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work. I appreciate it. Could you address my comments please? Thank you.

src/buffer.cpp Outdated Show resolved Hide resolved
src/rr.h Show resolved Hide resolved
src/rr.h Show resolved Hide resolved
@piz-ewing piz-ewing requested a review from mnezerka January 28, 2023 03:36
mnezerka
mnezerka requested changes Feb 25, 2023
View reviewed changes
Copy link
Owner

@mnezerka mnezerka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for delayed review. I was ill for a long time. Check my findings, please. Thank you for your work.

src/unittests.cpp Outdated Show resolved Hide resolved
src/buffer.cpp Show resolved Hide resolved
@piz-ewing piz-ewing requested a review from mnezerka February 27, 2023 04:03
@piz-ewing piz-ewing closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnezerka mnezerka Awaiting requested review from mnezerka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error when decoding compressed domain name
2 participants
@piz-ewing @mnezerka