Fix scaleMultiplier to be multiplicatively symmetrical #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here is that when you zoom out, you reduce the scale by a factor of 0.065, but when you zoom in, you increase the scale by the same additive factor, which is not multiplicatively symmetrical -- in order to undo multiplication by
0.935, you need to multiply by1.0695, not by1.065.You can see this erroneous behavior by zooming out one tick, then in one tick, then out one tick, so on and so forth -- it slowly continues to zoom out because the zoom in is slightly too little.