feat: remove menu in inspector

mob-sakai · Sep 1, 2020 · e7f8f51 · e7f8f51
1 parent 30b4703
commit e7f8f51
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 2 deletions.
diff --git a/Packages/UIParticle/Scripts/Editor/UIParticleEditor.cs b/Packages/UIParticle/Scripts/Editor/UIParticleEditor.cs
@@ -16,6 +16,9 @@ internal class UIParticleEditor : GraphicEditor
         //################################
         private static readonly GUIContent s_ContentRenderingOrder = new GUIContent("Rendering Order");
         private static readonly GUIContent s_ContentRefresh = new GUIContent("Refresh");
+        private static readonly GUIContent s_ContentFix = new GUIContent("Fix");
+        private static readonly List<UIParticle> s_TempParents = new List<UIParticle>();
+        private static readonly List<UIParticle> s_TempChildren = new List<UIParticle>();
 
         private SerializedProperty _spScale;
         private SerializedProperty _spIgnoreCanvasScaler;
@@ -101,6 +104,8 @@ public override void OnInspectorGUI()
 
             _ro.DoLayoutList();
 
+            serializedObject.ApplyModifiedProperties();
+
             // Does the shader support UI masks?
             if (current.maskable && current.GetComponentInParent<Mask>())
             {
@@ -118,7 +123,46 @@ public override void OnInspectorGUI()
                 }
             }
 
-            serializedObject.ApplyModifiedProperties();
+            // Does the shader support UI masks?
+
+            if (FixButton(current.m_IsTrail,"This UIParticle component should be removed. The UIParticle for trails is no longer needed."))
+            {
+                DestroyUIParticle(current);
+                return;
+            }
+            current.GetComponentsInParent(true, s_TempParents);
+            if (FixButton(1 < s_TempParents.Count,"This UIParticle component should be removed. The parent UIParticle exists."))
+            {
+                DestroyUIParticle(current);
+                return;
+            }
+            current.GetComponentsInChildren(true, s_TempChildren);
+            if (FixButton(1 < s_TempChildren.Count,"The children UIParticle component should be removed."))
+            {
+                s_TempChildren.ForEach(child => DestroyUIParticle(child, true));
+            }
+        }
+
+        void DestroyUIParticle(UIParticle p, bool ignoreCurrent = false)
+        {
+            if (!p || ignoreCurrent && target == p) return;
+
+            var cr = p.canvasRenderer;
+            DestroyImmediate(p);
+            DestroyImmediate(cr);
+        }
+
+        bool FixButton(bool show, string text)
+        {
+            if (!show) return false;
+            using (new EditorGUILayout.HorizontalScope(GUILayout.ExpandWidth(true)))
+            {
+                EditorGUILayout.HelpBox(text, MessageType.Warning, true);
+                using (new EditorGUILayout.VerticalScope())
+                {
+                    return GUILayout.Button(s_ContentFix, GUILayout.Width(30));
+                }
+            }
         }
     }
 }
diff --git a/Packages/UIParticle/Scripts/UIParticle.cs b/Packages/UIParticle/Scripts/UIParticle.cs
@@ -20,7 +20,7 @@ public class UIParticle : MaskableGraphic
         , ISerializationCallbackReceiver
 #endif
     {
-        [HideInInspector] [SerializeField] bool m_IsTrail = false;
+        [HideInInspector] [SerializeField] internal bool m_IsTrail = false;
 
         [Tooltip("Ignore canvas scaler")] [SerializeField] [FormerlySerializedAs("m_IgnoreParent")]
         bool m_IgnoreCanvasScaler = true;