Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_cachedPosition defaults to localPosition #121

Closed
danhines opened this issue Dec 7, 2020 · 2 comments
Closed

_cachedPosition defaults to localPosition #121

danhines opened this issue Dec 7, 2020 · 2 comments
Assignees
@mob-sakai
Labels
bug Something isn't working released

Comments

@danhines
Copy link

danhines commented Dec 7, 2020

I noticed that UIParticle._cachedPosition is being set to transform.localPosition inside UIParticle.OnEnable, whereas inside UIParticleUpdater.BakeMesh it is compared (& then set) to particle.transform.position. This seems to sometimes manifest as particles temporarily appearing at the wrong position if a particle system is moved while inactive and then re-enabled (I only saw this when m_IgnoreCanvasScaler was true).
@danhines danhines added the bug Something isn't working label Dec 7, 2020
@mob-sakai
Copy link
Owner

@danhines
Thank you for your reporting!

github-actions bot pushed a commit that referenced this issue Feb 1, 2021
@semantic-release-bot
chore(release): 3.3.2 [skip ci]
ba3b80d 
## [3.3.2](3.3.1...3.3.2) (2021-02-01)

### Bug Fixes

* _cachedPosition defaults to localPosition ([c0aa89b](c0aa89b)), closes [#121](#121)
* submeshes can't over 8 ([2a1f334](2a1f334)), closes [#122](#122)
@github-actions
Copy link

github-actions bot commented Feb 1, 2021

🎉 This issue has been resolved in version 3.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

LionelPerrault added a commit to LionelPerrault/Unity-Particle that referenced this issue Jul 25, 2023
@LionelPerrault
chore(release): 3.3.2 [skip ci]
bcf3adb 
## [3.3.2](mob-sakai/ParticleEffectForUGUI@3.3.1...3.3.2) (2021-02-01)

### Bug Fixes

* _cachedPosition defaults to localPosition ([c0aa89b](mob-sakai/ParticleEffectForUGUI@c0aa89b)), closes [#121](mob-sakai/ParticleEffectForUGUI#121)
* submeshes can't over 8 ([2a1f334](mob-sakai/ParticleEffectForUGUI@2a1f334)), closes [#122](mob-sakai/ParticleEffectForUGUI#122)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mob-sakai mob-sakai

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danhines @mob-sakai