Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added remove all on select #816

Merged
merged 6 commits into from
Aug 18, 2021
Merged

added remove all on select #816

merged 6 commits into from
Aug 18, 2021

Conversation

priyankafnu
Copy link
Contributor

@priyankafnu priyankafnu commented Aug 4, 2021 •
edited by grahamhency
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added
  • Docs have been added or updated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Style Update (CSS)
  • Other... Please describe:

What is the current behavior?

When a lot of results are selected, the "clear all" button appears way down the page in an unusual position.

What is the new behavior?

This adds a "remove all" button at the top of the select dropdown when items are selected to allow a user to easily remove all options when lots are selected.

Does this PR introduce a breaking change?

  • Yes
  • No

grahamhency
grahamhency suggested changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@grahamhency grahamhency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good. I had one additional suggestion and a comment on tests.

projects/go-lib/src/lib/components/go-select/go-select.component.html Show resolved Hide resolved
projects/go-lib/src/lib/components/go-select/go-select.component.ts Show resolved Hide resolved
@grahamhency grahamhency added feature New feature request in progress Work on this issue is in progress labels Aug 6, 2021
@jeffrlynn jeffrlynn removed their request for review August 6, 2021 15:25
@jeffrlynn jeffrlynn removed their request for review August 11, 2021 19:56
grahamhency
grahamhency suggested changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@grahamhency grahamhency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more comment, but if you can address that I'll approve and we can get a new version ready.

projects/go-lib/src/lib/components/go-select/go-select.component.html Show resolved Hide resolved
@grahamhency grahamhency merged commit 497b7f1 into dev Aug 18, 2021
@grahamhency grahamhency deleted the feature/remove-all-TME-257 branch August 18, 2021 15:11
@grahamhency grahamhency mentioned this pull request Aug 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamhency grahamhency grahamhency approved these changes

Assignees
No one assigned
Labels
feature New feature request in progress Work on this issue is in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@priyankafnu @grahamhency