[Feature] go-table wrapContent #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamhency
requested review from
schneiderduketangoe
and removed request for
swimtech20
schneiderduketangoe
previously approved these changes
Aug 18, 2021
projects/go-lib/src/lib/components/go-table/go-table-column.component.ts
Show resolved
Hide resolved
grahamhency
force-pushed
the
feature_table_wrapContent
branch
from
fcdb904 to
8525af8
Compare
|
@schneiderduketangoe I had to rebase and also explained my thought process, would you mind approving again? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
- [ ] Tests for the changes have been addedPR Type
What kind of change does this PR introduce?
What is the current behavior?
Resolves #811
What is the new behavior?
Added a binding to the
go-tablecomponent calledwrapContentthat controls whether the content in all of the table cells wraps or not.Added a binding to the
go-table-columncomponent calledwrapContentthat controls the content wrapping for that individual column. Note: this binding will override thewrapContentbinding on thego-tablefor that individual column.Does this PR introduce a breaking change?