New asset: download webcam images #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for book-keeping purposes: dagster-io/dagster#25490 |
derhuerst
approved these changes
Oct 24, 2024
pipeline/__init__.py
Outdated
| from .resources import JsonWebAssetIOManager, LamassuResource, PostGISGeoPandasIOManager | ||
| from .resources.gdal import Ogr2OgrResource | ||
|
|
||
| assets = load_assets_from_modules([sharing, radvis, gtfs, traffic_incidents]) | ||
| assets = load_assets_from_modules([sharing, radvis, gtfs, traffic_incidents, webcams]) |
There was a problem hiding this comment.
Shall we make this multi-line, in order to have a git blame-able formatting from now on?
Suggested change
| assets = load_assets_from_modules([sharing, radvis, gtfs, traffic_incidents, webcams]) | |
| assets = load_assets_from_modules([ | |
| sharing, | |
| radvis, | |
| gtfs, | |
| traffic_incidents, | |
| webcams | |
| ]) |
| asset, | ||
| ) | ||
|
|
||
| SCRIPT_DIR = os.getenv('SCRIPT_DIR', './scripts/') |
There was a problem hiding this comment.
Should SCRIPT_DIR be relative to $PWD or to this file's path?
scripts/download_webcams.sh
Outdated
| @@ -0,0 +1,5 @@ | |||
| set -eo pipefail | |||
|
|
|||
| echo Download webcams | |||
There was a problem hiding this comment.
Typically, status/progress messages should be written to stderr, so that the actual commands' outputs can be processed via stdout.
Suggested change
| echo Download webcams | |
| 1>&2 echo 'Downloading webcam images' |
hbruch
changed the title
the-infinity
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
webcam_imagesasset, which is materialized via a shell script wich transfers them via lftp.Dagster will only execute one materialization in parallel, so this asset may perform an initially long running transfer followed by (currently minutely executed) transfer jobs.
In case of a non-zero exit code of the shell script, a
RuntimeExceptionwill be thrown which fails the materialization.stdoutandstderrof the shell script are both captured and logged on the job's stderr.NOTE: this PR is still WIP. I.e. the script needs to be implemented (or mounted from another place). In case further env variables are intended to be propagated to the script, these would need to be handled as well.