-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reserved Token IDs #45
Conversation
As a result, the primary purpose of this change is to ensure that the same token ID is not re-used on a given network, but secondarily to ensure that a given token ID is also not re-used *between* networks. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would think that we would want to allow main net token ids on the test net in order to better simulate tokens on mainnet, prior to them being on mainnet.
Is the desire that one spins up their own local network for these kind of tests and sanity checks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am worried that this compromises our ability to properly test clients in testnet before we go live in mainnet with important synthetic assets.
I think this proposal should be at a minimum be reworked to explain how clients are supposed to be tested if we adopt this proposal. I think this proposal is non-viable because of the difficulty it creates for this.
I think we should also have a more serious discussion of the alternatives in rationale and alternatives. There are easy ways to handle "de-confliction" of networks, which is an important problem that affects all features and not just confidential tokens. Instead of fragmenting configuration across all networks maybe we should come up with unified way to deal with de-confliction, and then everything else will become simpler.
I posted a proposal here to explain what I have in mind: #49 What I would like is that, token ids that appear in prod are okay to appear in test and dev, and token ids that appear in test are okay to appear in dev. This allows that we can roll out a specific new token id through testing at each layer of the system before we go live, and we don't need to have network-specific token metadata. The network id mechanism can be used to prevent mixing of networks. I think that's simpler overall, and it means that we can test almost exactly what we will push to prod before we do it. I'm worried that we could ship broken software if we don't make it so that we can test it properly. |
Rendered Proposal