-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixups/statefilerecovery #1358
Fixups/statefilerecovery #1358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some stylistic issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't add the partially initialized state stuff
- It seems like this state should not be leaving the ingest node and be communciated to overseer or anyone else
- If more work needs to happen to get it into a healthy state, then it should do that work itself and then become fully initialized. If no one else needs to know about it then don't put it in controller state.
- Adding more and more states to the system increases its complexity, this should not be done casually and especially not when the additional state is dead code. There need to be wide-ranging discussions including all fog eng's and ops if ingest is going to have an increased number of states and behaviors. So adding this now may be premature
I agree with this after consideration. I had been initially concerned about the possibility of being in a partially initialized state. But I feel like the code has sufficient safety around the scenario where it fails to set_peers or otherwise that it is not necessary to add this code, which I agree is currently dead. It can be added in the future as needed with Fog Overseer. I think it is safe to be just set to idle with no other flags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thank you!
Soundtrack of this PR: link to song that really fits the mood of this PR
Motivation
Better state file management to avoid losing a relevant key. Based on this PR by @garbageslam: #1085
In this PR
This resolve issue #1082
Future Work