Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Changelog and Versions #2007

Merged
merged 13 commits into from
May 20, 2022
Merged

Update Changelog and Versions #2007

merged 13 commits into from
May 20, 2022

Conversation

jcape
Copy link
Contributor

@jcape jcape commented May 19, 2022 •
edited
Loading

  • Update all crate versions to 1.2.0-pre0.
  • Update CHANGELOG.md for changes since the 1.1.1 consensus release.

Motivation

Paperwork for 1.2.0-pre0 release.

@jcape jcape self-assigned this May 19, 2022
@jcape jcape added this to the 1.2.0 Release milestone May 19, 2022
cbeck88
cbeck88 reviewed May 19, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@jcape jcape marked this pull request as ready for review May 19, 2022 21:32
@jcape jcape requested review from remoun and eranrund May 19, 2022 21:32
eranrund
eranrund approved these changes May 19, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
jcape and others added 2 commits May 19, 2022 15:34
remoun
remoun reviewed May 19, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
remoun
remoun reviewed May 19, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@remoun remoun mentioned this pull request May 19, 2022
Merged
nick-mobilecoin added a commit that referenced this pull request May 19, 2022
@nick-mobilecoin
Revert changelog entry
7c447e2 
Leveraging #2007
for the update
nick-mobilecoin added a commit that referenced this pull request May 20, 2022
@nick-mobilecoin
Feature/candidate 1 2 sgx 2 16 (#2018)
0331a58 
* Feature/sgx 2 16 (#2011)

* Update sgx to 2.16

* Update the docker image

* Fix circle CI docker version

* Update instruction in markdown

Also add comment explaining order of command

* Revert changelog entry

Leveraging #2007
for the update
James Cape and others added 5 commits May 19, 2022 23:43
cbeck88
cbeck88 reviewed May 20, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
cbeck88
cbeck88 reviewed May 20, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
cbeck88
cbeck88 previously requested changes May 20, 2022
View reviewed changes
Copy link
Contributor

@cbeck88 cbeck88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is missing references to MCIP 37, that's the only issue I see

remoun
remoun approved these changes May 20, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jcape @remoun
Apply suggestions from code review
73ca4d1 
Co-authored-by: Chris Beck <garbageslamb@gmail.com>
Co-authored-by: Remoun Metyas <remoun.metyas@gmail.com>
@jcape jcape requested a review from cbeck88 May 20, 2022 18:58
@jcape @remoun
Apply suggestions from code review
0de25e3 
(this will require a follow-up commit to fix links)

Co-authored-by: Remoun Metyas <remoun.metyas@gmail.com>
remoun
remoun approved these changes May 20, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@jcape jcape dismissed cbeck88’s stale review May 20, 2022 20:27

Changes have been integrated

@jcape jcape merged commit f447891 into mobilecoinfoundation:candidate-1.2 May 20, 2022
@jcape jcape deleted the changelog-and-version-for-candidate-1.2 branch May 20, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eranrund eranrund eranrund approved these changes

@remoun remoun remoun approved these changes

@cbeck88 cbeck88 Awaiting requested review from cbeck88

Assignees

@jcape jcape

Labels
None yet
Projects
Blockchain Core
Archived in project
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jcape @remoun @eranrund @cbeck88